Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows porting [WORK IN PROGRESS] [DO NOT REVIEW] #2629

Open
wants to merge 32 commits into
base: dev
Choose a base branch
from

Conversation

NoamDev
Copy link

@NoamDev NoamDev commented Jul 2, 2020

Issue: #2627

@devops-mycroft
Copy link

Hello, @NoamDev, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Jul 2, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@pep8speaks
Copy link

pep8speaks commented Jul 2, 2020

Hello @NoamDev! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:1: E302 expected 2 blank lines, found 1
Line 18:1: E305 expected 2 blank lines after class or function definition, found 1
Line 18:80: E501 line too long (92 > 79 characters)
Line 22:80: E501 line too long (84 > 79 characters)
Line 24:1: W293 blank line contains whitespace
Line 26:54: W292 no newline at end of file

Comment last updated at 2021-02-01 12:49:05 UTC

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

1 similar comment
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Jul 2, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

5 similar comments
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added the Status: Work in progress PR being actively worked on, not yet ready for review. label Aug 11, 2020
@krisgesling krisgesling added this to Inbox in Roadmap via automation Sep 24, 2020
@krisgesling krisgesling moved this from Inbox to Nice to have in Roadmap Sep 24, 2020
@krisgesling krisgesling added the Type: Enhancement - roadmapped Implementation of a feature that is a priority on the roadmap. label Sep 24, 2020
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

2 similar comments
@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) Status: Work in progress PR being actively worked on, not yet ready for review. Type: Enhancement - roadmapped Implementation of a feature that is a priority on the roadmap.
Projects
Roadmap
  
Nice to have
Development

Successfully merging this pull request may close these issues.

None yet

4 participants