Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gTTS to version 2.2.0 #2763

Merged
merged 1 commit into from Nov 16, 2020
Merged

Conversation

marvin-w
Copy link
Contributor

@marvin-w marvin-w commented Nov 15, 2020

Description

This PR updates gTTS to version 2.2.0 which has been adjusted to properly use the new Google "API" for TTS.

See https://github.com/Boudewijn26/gTTS-token/blob/master/docs/november-2020-translate-changes.md for details

Also pndurette/gTTS#232 might be useful for information gathering.

How to test

(Description of how to validate or test this PR)

Verify Google TTS is working correctly now.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label Nov 15, 2020
@devops-mycroft
Copy link

Hello, @marvin-w, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@marvin-w
Copy link
Contributor Author

CLA signed.

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results)

@forslund
Copy link
Collaborator

Tested and works excellently, Thanks for contributing the update. After CLA is received this can be merged 👍

@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling krisgesling added CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) and removed CLA: Needed Need signed CLA from https://mycroft.ai/cla labels Nov 16, 2020
@krisgesling
Copy link
Contributor

Thanks Marvin, CLA received and you've been added to our list of excellent humans

@krisgesling krisgesling merged commit c81f20d into MycroftAI:dev Nov 16, 2020
@marvin-w marvin-w deleted the update-gtts branch November 16, 2020 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants