Refactor mimic_tts to not load config when importing #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forslund
added
the
Type: Refactoring and other improvements
devops-mycroft
added
the
CLA: Yes
Codecov Report
@@ Coverage Diff @@
## dev #2888 +/- ##
==========================================
+ Coverage 52.59% 52.62% +0.02%
==========================================
Files 123 123
Lines 10989 10997 +8
==========================================
+ Hits 5780 5787 +7
- Misses 5209 5210 +1
Continue to review full report at Codecov.
|
JarbasAl
reviewed
Apr 28, 2021
|
Voight Kampff Integration Test Succeeded (Results) |
Hitting the entire configuration fetching routine with call to the backend is not polite to do when just importing the file. This moves the config lookup out of the global scope and into special functions for finding the mimic binary and looking up the data path for the subscriber voices.
Default config will generally always have a mimic block but in combination with newer Mycroft variants a more defensive approach is probably good
forslund
force-pushed
the
refactor/mimic_tts-dont-load-config-on-import
branch
from
5e965d4
to
d884da5
Compare
|
Voight Kampff Integration Test Failed (Results). |
1 similar comment
|
Voight Kampff Integration Test Failed (Results). |
|
Voight Kampff Integration Test Succeeded (Results) |
krisgesling
added
Merge after next release
krisgesling
approved these changes
May 11, 2021
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
May 13, 2021
this commit should be dropped in next rebase/sync with mycroft-core
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
May 14, 2021
- backport MycroftAI#2888 - dont load remote config unless needed - identity file handling tweaks - dont auto create xdg paths (this was triggering some race conditions that killed the whole process when multiple places attempted to create the folder at same time, a simple string definition should not be creating directories)
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
May 14, 2021
adds XDG support
JarbasAl
added a commit
to HelloChatterbox/HolmesIV
that referenced
this pull request
May 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hitting the entire configuration fetching routine with call to the backend is not polite to do when just importing the file. This moves the config lookup out of the global scope and into special functions for finding the mimic binary and looking up the data path for the subscriber voices.
How to test
Ensure that the unittests still work and that the good old Alan Pope voice can be heard :)
Contributor license agreement signed?
CLA [ Yes ]