Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added blackPanther support #2922

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Added blackPanther support #2922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 13 additions & 0 deletions dev_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,15 @@ function fedora_install() {
$SUDO dnf install -y git python3 python3-devel python3-pip python3-setuptools python3-virtualenv pygobject3-devel libtool libffi-devel openssl-devel autoconf bison swig glib2-devel portaudio-devel mpg123 mpg123-plugins-pulseaudio screen curl pkgconfig libicu-devel automake libjpeg-turbo-devel fann-devel gcc-c++ redhat-rpm-config jq make
}

function blackpanther_install() {
if [ -x /usr/bin/sudo ];then
$SUDO installing git python3 python3-devel python3-pip python3-setuptools python3-virtualenv python-gobject3-devel libtool lib64ffi-devel openssl-devel autoconf bison swig glib2-devel portaudio-devel mpg123 mpg123-pulse screen curl pkgconfig lib64icu-devel automake lib64jpeg-devel lib64fann-devel gcc-c++ jq make
else
# own authentication without sudo
installing git python3 python3-devel python3-pip python3-setuptools python3-virtualenv python-gobject3-devel libtool lib64ffi-devel openssl-devel autoconf bison swig glib2-devel portaudio-devel mpg123 mpg123-pulse screen curl pkgconfig lib64icu-devel automake lib64jpeg--devel lib64fann-devel gcc-c++ jq make
fi
Comment on lines +373 to +378
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that the else path on this conditional will ever be executed.

If sudo isn't on the system then the found_exe sudo up around line 129 will fail and the script will exit. Have you tested this path out? I'm not at all familiar with this distro or the packaging manager it uses.

We do handle this better in Pako now, which is what we use for installing system packages for Skills etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, because the blackPanther don't use sudo for authentication on the default installed system, but contain a wrapper on different path (the name is sudo), and system allows install sudo package if user want to this path: /usr/bin/sudo. Another way for 'detect', example if found_exe find it the autentication will not work on blackPanther OS. (or requires sudo install too)
Sorry I I'm too late for response, we work on many project in same time in our distro.

}


function arch_install() {
$SUDO pacman -S --needed --noconfirm git python python-pip python-setuptools python-virtualenv python-gobject libffi swig portaudio mpg123 screen flac curl icu libjpeg-turbo base-devel jq pulseaudio pulseaudio-alsa
Expand Down Expand Up @@ -423,6 +432,10 @@ function install_deps() {
# Debian / Ubuntu / Mint
echo "$GREEN Installing packages for Debian/Ubuntu/Mint...$RESET"
debian_install
elif found_exe installing && os_is blackpantheros; then
# Fedora
echo "$GREEN Installing packages for blackPanther OS...$RESET"
blackpanther_install
elif os_is_like fedora || os_is fedora; then
# Fedora
echo "$GREEN Installing packages for Fedora...$RESET"
Expand Down