Stop creation of 'None' cache directory #2931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
persistent_cache_dir
is assignedNone
if nopreloaded_cache
exists.None
was then created as a directory when it's clearly not needed.Re-ordered slightly to keep all the directory setting and checking together.
Fixes #2930
Thanks to @JarbasAI for the fix
How to test
mycroft-core/None
directory is created.Contributor license agreement signed?