External enable/disable intent #860
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JarbasAI thank you that's a cool feature, can you fix the tests so we can merge it :) |
penrods
added
the
CLA: Yes
|
rebased |
|
https://github.com/JarbasAl/mycroft_jarbas_utils needs this PR |
|
Will review tomorrow! |
Allow intents to be enabled or disabled from outside needed for example in my intent_layers helper class to control what intents are active
|
Could have sworn I posted a message earlier. Looks and works good. Only thing I'd like to change is the name of the messages. |
|
With the update it looks good. I'll rebase it and squash it into a single commit and get it merged in the morning. |
|
Merged via #1524, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow intents to be enabled or disabled from outside the skill itself
needed for example in my intent_layers helper class to control what intents are active