Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding commit template and dev_setup.sh support #952

Merged
merged 2 commits into from Aug 2, 2017

Conversation

penrods
Copy link
Contributor

@penrods penrods commented Aug 2, 2017

The commit template provides a developer with a structure to follow
for communicating with others on the mycroft-core project.

==== Tech Notes ====
Please use this template from here on!

The commit template provides a developer with a structure to follow
for communicating with others on the mycroft-core project.

====  Tech Notes ====
Please use this template from here on!
@penrods penrods requested a review from aatchison August 2, 2017 17:23
@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.314% when pulling 329db01 on feature/commit-template into 9887009 on dev.

Add grammar suggestions for consistent git messages.  Following the same
mood makes generation of release notes and working in Github in general
easier.

Based on comments found at:
http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html
@coveralls
Copy link

Coverage Status

Coverage remained the same at 41.314% when pulling f435c78 on feature/commit-template into 9887009 on dev.

Copy link
Contributor

@aatchison aatchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great.
We should add something to the README.md to specify not to use git commit -m and just git commit

@aatchison aatchison merged commit a3feed6 into dev Aug 2, 2017
@aatchison aatchison deleted the feature/commit-template branch August 2, 2017 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants