Upgrade mycroft-weather

[chrisveilleux]

This upgrades mycroft-weather to include the following new commits:

• Merge pull request #165 from emphasize/fix/percnumber_placeholder
• fix the percentage-number placeholder name
• Merge pull request #162 from MycroftAI/20.08
• Merge pull request #158 from MycroftAI/make-weather-great-again
• Move the rest of the old dialog class to the new ones.
• fix VK test failures.
• fixed errant dialog names found in VK testing.
• apply new dialog file naming convention to tests.
• resolve merge conflicts
• Merge remote-tracking branch 'origin/20.08' into make-weather-great-again
• use the new CardDelegate defined in the mycroft-gui repository to abstract some of the grid-style card layout commonalities.
• applied code review changes
• renamed dialog and vocab files to be lower case and dash delimited.
• added location data to the forecast screen
• small bug fix
• tweaks to GUI screens based on design changes
• renamed "source" directory to "skill"
• Added location to the top of weather screens that didn't have it.
• Refactored logic that selected an image or animation to use in the GUI
• Add a new GUI screen for sunrise and sunset.
• Add a new GUI screen for a single day of weather.
• Bug fixes
• Second pass at refactoring, including reworking the dialog classes, removing a bunch of condition specific dialog files, code review changes and other minor cleanups.
• Renamed resource files to be consistent with en-us locale.
• Add OpenWeatherMap language support.
• Add PyCharm IDE files to gitignore
• Move dialog, vocabulary and regex files to the locale directory as per the latest convention.
• New xfail scenario example
• New feature files for hourly weather
• Minor font size change
• Remove unused import
• Take today out of the relative day vocabulary file as it was conflicting with some of the current weather intents.
• Add index out of range handling for hourly requests more than 48 hours in the future and daily requests more than seven days in the future
• Uncomment the feature files.
• Renamed delegates for consistency, added abstractions to reduce code duplication.
• Introduce a 16 pixel grid unit property and remove an unused import
• Fixed a bug introduced during code cleanup
• Added comments
• Added comments and formatting.
• Add documentation and rename the "generic" QML files to a more descriptive "scalable"
• Add a section for temperatures
• Added license information block.
• Removed unused QML file
• Update the README file.
• Refactor the GUI code. Add Mark II specific QML files.
• refactor weather skill
• Merge pull request #160 from AIIX/fix-resizing-bug-remove-autofit
• fix scaling for forecast delegate and weather page text alignment
• make sure the background is black
• Fix text resizing issue remove autofit label
• Merge branch '20.08' into make-weather-great-again

_{Created with mycroft-skills-kit v0.3.16}

[krisgesling]

The only failure seems to be the timeout of the test as there have been so many additions to the default Skills.

I know we've talked about many ideas for improving the test framework as a whole, but it seems like we need to figure out a shorter-term strategy to get us through for the moment.

We could do something like MycroftAI/mycroft-core#2811 to run the tests in parallel?
Or disable a proportion of the tests and only run a subset during the CI?

[forslund]

The first batch of tests for the weather skill fails, this could be a source of the extreme runtime (540s) of the tests since each failure has a 10 second timeout and will trigger a retry so each fail will add at least 20 seconds per failing scenario.

A simple thing to do for now is to extend the job timeout to 90 minutes just to get a feeling for what is taking so long?

[krisgesling]

Yeah, I was wanting to get a version of your Parallel Skill Tester PR in instead, but I haven't got that ready, so have instead done the quick fix of extending the job timeout. At least we'll unblock PR's temporarily.

[devops-mycroft]

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[devops-mycroft]

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[devops-mycroft]

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[devops-mycroft]

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[devops-mycroft]

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[devops-mycroft]

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

[devops-mycroft]

Voight Kampff Integration Test Succeeded (Results)