Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change meta_editor hotlink from rawgit to rawgithack. Fixes #618 #626

Merged
merged 1 commit into from Oct 24, 2018

Conversation

rizdaprasetya
Copy link
Contributor

Description:

This should fix #618
Rawgithack is similar implementation of Rawgit.
I changed meta_editor.html hotlink from Rawgit to Rawgithack, so that people can still access the hosted html page easily using browser.

What do you think? Feel free to edit or suggest alternative.

Checklist:

  • Has been tested and works

Demo

https://raw.githack.com/MycroftAI/mycroft-skills/18.08/meta_editor.html

@forslund
Copy link
Collaborator

This sounds like an excellent replacement! Is this a development url or a production url?

I think @penrods and @KathyReid and the skills team will be the ones making the decision on this.

@rizdaprasetya
Copy link
Contributor Author

@forslund that's a development URL, I think the production url is not suitable because the content is cached for about a year, which might prevent new changes reflected to the url.

@forslund
Copy link
Collaborator

Ah yes, that's a bit long :)

@KathyReid
Copy link
Contributor

Terima kasih atas PR Anda :-) Solusi ini bagus.

I've read through the information at http://raw.githack.com/#faq, and in particular the information about "don't use a development URL in production". It is OK for us to use a development URL for the Meta Editor, because it is very low traffic.

I'm going to make the decision on this without bouncing off @penrods; it is straightforward and low risk.

Sekarang, PR ini akan digabung.

@KathyReid KathyReid merged commit 7bc43b2 into MycroftAI:18.08 Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants