Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding initial CONTRIBUTING.md file #777

Merged
merged 5 commits into from Jan 22, 2019
Merged

Adding initial CONTRIBUTING.md file #777

merged 5 commits into from Jan 22, 2019

Conversation

penrods
Copy link
Contributor

@penrods penrods commented Jan 17, 2019

Add a CONTRIBUTING guide.

penrods and others added 2 commits January 17, 2019 04:14
Good call on this, really I should have had a CONTRIBUTING file here ages ago. 
Some minor questions; 

* I've been using the capitalisation `Skills` on all our documentation - as it denotes a certain importance to Skills. I'd like to do same here but thought it was really nitpicking to do so and wanted to check first. 

* Do we want to push people to list their Skill on the Skill Feedback topic on the Forum first before submitting here to make sure it works and the "tougher" testing that is done here is not wasted? 

Also, feel free to tell me to stop sticking my beak in; not my paddock any more! ;-)
CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor Author

@penrods penrods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All sounds good to me. This is still your paddock too! :)

```
mycroft-msk submit <local-path-to-your-skill>
```

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might want to add something like:

Note: If you have two-factor authentication enabled for github, you will need to generate a [personal access token](https://help.github.com/articles/creating-a-personal-access-token-for-the-command-line/) and use the `-t` flag. E.g.

    mycroft-msk -t submit <local-path-to-your-skill>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@forslund
Copy link
Collaborator

Since there's not been any new comments on this one for the past five days, can we merge it as it stands now?

@el-tocino el-tocino merged commit d4329af into 18.08 Jan 22, 2019
@forslund forslund deleted the feature/contributing branch February 27, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants