Bugfix - tests failing on slow responses #46
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of tests are currently failing for the Wiki Skill, caused by the delay in responding exceeding the default 10 second Voight Kampff Step timeout.
This adds a custom
wait while speaking
step to delay the start of the finalmycroft reply should contain
step for each test. An additional 3 second sleep was added to this to ensure some delay occured given the Docker runs use a dummy TTS and hence wouldn't pause.This is intended to get the VK tests passing in the short term. More thought needs to go into the best way to handle this going forward to make the test suite more robust.
We also need to investigate ways to speed up the response time from the wikipedia service. A user shouldn't need to wait > 10 seconds for an answer. Options are to switch libraries or reduce the search calls. Currently for a single search we can make up to 3 requests to wikipedia as we: