Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace overture with kotlin? #2

Closed
wants to merge 2 commits into from
Closed

Replace overture with kotlin? #2

wants to merge 2 commits into from

Conversation

Mygod
Copy link
Owner

@Mygod Mygod commented Jan 28, 2019

Yeah, with this we will no longer need overture methinks. So check it out IDK cuz I am not gonna touch this for a while. @madeye

Nothing works yet (well actually receiving DNS and local resolver work) and somebody just needs to debug this I guess.

See also PR for dnsproxyd: shadowsocks#2092

[With this PR, we] can also respect local DNS settings (fix shadowsocks#2016), and therefore including possibly support private DNS on Android 9+ (see also shadowsocks#2015).

P.S. It seems like private DNS is not working on my side with Wi-Fi + VPN but works fine with mobile data + VPN. Can anyone also confirm this?

@Mygod Mygod changed the title Initial draft for LocalDnsServer Replace overture with kotlin? Jan 28, 2019
@Mygod
Copy link
Owner Author

Mygod commented Jan 28, 2019

@madeye Meanwhile, we can choose to do either: (if you think dnsproxyd is good enough, I think it looks to me for now)

  • Merge Mygod:dnsproxyd -> shadowsocks:master and move this PR to shadowsocks;
  • Push Mygod:dnsproxyd -> shadowsocks:dnsproxyd and move this PR to shadowsocks.

@Mygod
Copy link
Owner Author

Mygod commented Jan 28, 2019

Also I believe Kotlin coroutines have comparable performance with goroutines [1] [2] [3], but obviously that needs fine tuning. The current code probably runs a little slow but again code in overture was not written with great care either.

@madeye
Copy link
Collaborator

madeye commented Jan 28, 2019

Yeah, let's move this PR to shadowsocks first.

@Mygod Mygod closed this Jan 29, 2019
Repository owner locked as resolved and limited conversation to collaborators Jan 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants