More fixes #10
Merged
More fixes #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ended up with quite a few changes here. Big things are better apostrophe handling in function arguments and fixed an issue where unit test runs were overriding the test resource tree contents. It should still be at 100%, and everything builds and runs happily. I think this should be ready for another merge, with only some extremely minor polishing left. |
|
Final polishing on this PR and merge. Next comes modifying the action class to visit individual function calls and groups of function calls. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to get this to apply changes right to the EnergyPlus codebase, run Clang Format, and it builds and tests happily. When you run Git Diff on it, there are a handful of files with changes, only because of comment diffs. This is ready for action.