Skip to content
This repository has been archived by the owner on Jun 19, 2022. It is now read-only.

Merge titlebar #141

Closed
wants to merge 6 commits into from
Closed

Merge titlebar #141

wants to merge 6 commits into from

Conversation

Zxnii
Copy link

@Zxnii Zxnii commented May 6, 2022

Merge titlebar into the window (lots of commits I know, I kept breaking things)

Windows:
image
MacOS:
image

@@ -1,7 +1,7 @@
{
"name": "ninetails",
"productName": "Ninetails",
"version": "3.8.0",
"version": "3.9.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bumping the version; I often forget. 🤣

@@ -1,132 +1,201 @@
<!DOCTYPE html>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the formatting, could you revert it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure can, i forgot i had my code formatter on so i can revert it

@MystPi
Copy link
Owner

MystPi commented May 6, 2022

I'm not so sure about this... I'll think about it.

@webdev03
Copy link
Contributor

webdev03 commented May 7, 2022

What about Linux and desktop environment things? Would this be disabled for Linux right?
0abbe46 didn't see

@Zxnii
Copy link
Author

Zxnii commented May 7, 2022

yeah its disabled for linux, in future i think it'd be cool to hook into gtk and implement a custom titlebar

@github-actions
Copy link

github-actions bot commented Jun 6, 2022

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jun 6, 2022
@github-actions github-actions bot closed this Jun 11, 2022
@Zxnii Zxnii deleted the titlebar branch June 11, 2022 18:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants