Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc fixes and refactoring in bulletproof module #794

Merged
merged 4 commits into from
May 24, 2024

Conversation

jonas-lj
Copy link
Contributor

No description provided.

@jonas-lj jonas-lj marked this pull request as ready for review May 23, 2024 08:28
@jonas-lj jonas-lj requested a review from joyqvq May 23, 2024 08:28
}
}

impl Eq for PedersenCommitment {}

impl PartialOrd for PedersenCommitment {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these (PartialOrd and Ord) really needed?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this for sui later? we dont have to add now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add them later if they are needed.

Copy link
Collaborator

@joyqvq joyqvq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm


//
// Pedersen commitments
//

// TODO: The scalars (value and blinding) are created from the lower 255 bits of a 256 bit scalar, so we should require that the last bit is zero or use the scalars directly.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jonas-lj jonas-lj merged commit e8ce79a into main May 24, 2024
7 checks passed
@jonas-lj jonas-lj deleted the jonas/bulletproof_clean_up branch May 24, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants