Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring class group code #795

Merged
merged 3 commits into from
May 27, 2024
Merged

Refactoring class group code #795

merged 3 commits into from
May 27, 2024

Conversation

jonas-lj
Copy link
Contributor

@jonas-lj jonas-lj commented May 23, 2024 •
edited

  • Rename has_parameter to is_in_group.
  • Refactor computations in form composition.

@jonas-lj jonas-lj changed the title Small clean ups Small clean ups in class group code May 23, 2024
@jonas-lj jonas-lj changed the title Small clean ups in class group code Refactoring class group code May 23, 2024
@jonas-lj jonas-lj requested a review from benr-ml May 27, 2024 08:59
@jonas-lj jonas-lj marked this pull request as ready for review May 27, 2024 08:59
@jonas-lj jonas-lj merged commit 7175313 into main May 27, 2024
13 checks passed
@jonas-lj jonas-lj deleted the jonas/cg_clean branch May 27, 2024 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benr-ml benr-ml benr-ml approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonas-lj @benr-ml