Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poseidon clean up #796

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Poseidon clean up #796

merged 2 commits into from
Jun 11, 2024

Conversation

jonas-lj
Copy link
Contributor

@jonas-lj jonas-lj commented May 24, 2024 •
edited
Loading

Small clean ups:

  • Docs
  • Use iterator when possible
  • InputTooLong takes the target size as parameter, not the actual size.

@jonas-lj jonas-lj marked this pull request as ready for review May 27, 2024 09:14
@jonas-lj jonas-lj requested a review from joyqvq June 5, 2024 09:56
joyqvq
joyqvq approved these changes Jun 10, 2024
View reviewed changes
Copy link
Collaborator

@joyqvq joyqvq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, is the plan to use this for zklogin util as well or just the poseidon move impl?

@jonas-lj
Copy link
Contributor Author

lgtm, is the plan to use this for zklogin util as well or just the poseidon move impl?

It'll also be used in zklogin, but the behaviour doesn't change.

@jonas-lj jonas-lj merged commit 269eca3 into main Jun 11, 2024
13 checks passed
@jonas-lj jonas-lj deleted the jonas/poseidon_clean_up branch June 11, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyqvq joyqvq joyqvq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonas-lj @joyqvq