Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fastcrypto - includes an update to ECVRF which is not backward compatible with previous ECVRF proofs. #10332

Merged
merged 2 commits into from
Apr 3, 2023

Conversation

benr-ml
Copy link
Contributor

@benr-ml benr-ml commented Apr 3, 2023

Description

Update fastcrypto - includes an update to ECVRF which is not backward compatible with previous ECVRF proofs.

Test Plan

All tests pass


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Update fastcrypto - includes an update to ECVRF which is not backward compatible with previous ECVRF proofs.

@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Apr 3, 2023 5:30pm
explorer-storybook ⬜️ Ignored (Inspect) Apr 3, 2023 5:30pm
sui-wallet-kit ⬜️ Ignored (Inspect) Apr 3, 2023 5:30pm
wallet-adapter ⬜️ Ignored (Inspect) Apr 3, 2023 5:30pm

@benr-ml benr-ml marked this pull request as ready for review April 3, 2023 16:53
@benr-ml benr-ml requested review from kchalkias and joyqvq April 3, 2023 16:54
Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting that we update + add (ie rsa and co) so many deps.

@benr-ml
Copy link
Contributor Author

benr-ml commented Apr 3, 2023

interesting that we update + add (ie rsa and co) so many deps.

it's because dependabot updated a few conflicting packages since our last merge into sui, and I didn't want to revert its changes. we should stop dependabot from running in fastcrypto.

@benr-ml
Copy link
Contributor Author

benr-ml commented Apr 3, 2023

actually it's not dependabot, we updated a few packages in fastcrypto manually

Copy link
Collaborator

@kchalkias kchalkias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, need to update release notes for 0.3

@benr-ml benr-ml merged commit 93cfbf5 into main Apr 3, 2023
@benr-ml benr-ml deleted the ben/update_crypto branch April 3, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants