[sui-system] remove unused code and correct variable naming #12321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
emmazzz
force-pushed
the
emma/unused-staking
branch
from
592e16a
to
a5419de
Compare
lxfind
approved these changes
Jun 2, 2023
ebmifa
added a commit
that referenced
this pull request
Jun 15, 2023
## Description Release Notes PR checker and generator ## Test Plan ``` eugene@mac-studio ~/code/sui (eugene/create_release_notes_workflow) $ ./scripts/generate-release-notes.sh releases/sui-v1.3.0-release releases/sui-v1.2.0-release #12359: #12444: Introduce new modules: `clob_v2` and `custodian_v2` and deprecate `clob` and `custodian`. #12231: Adds the checkpoint low watermark for state sync. This lets a node to know who to query checkpoint contents according to the watermarks, once checkpoint pruning is enabled. #12321: #12251: #12092: Added a version of stake withdraw function that returns the withdrawn SUI tokens, for better composability. #12258: #12171: update anemo to MystenLabs/anemo@1bfa784 which includes the `alternate_server_name` change. Set primary server name as `sui-{chain-id}`. Note that if node starts to run this version in testnet/mainnet before the update is officially rolled out, it's likely the node won't be able to state sync. #12043: - adds `sui::kiosk::default()` function for easy Kiosk setup ``` Will test the workflows once this PR lands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
request_withdraw_stake_preactivewas never used so it's removed.derive_reference_gas_pricewe are using voting power, not stake.Test Plan
How did you test the new or updated feature?
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes