Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose EC APIs for BLS12-381 #12337

Merged
merged 5 commits into from
Jan 31, 2024
Merged

Expose EC APIs for BLS12-381 #12337

merged 5 commits into from
Jan 31, 2024

Conversation

benr-ml
Copy link
Contributor

@benr-ml benr-ml commented Jun 5, 2023

Description

Add Move modules for BLS12-381 group operations.
Ristretto group operations can be added in the future (tested in https://github.com/MystenLabs/sui/tree/ben/ecops_rist).
Enabled in devnet only.

Test Plan

Existing and many newly added tests.

Type of Change (Check all that apply)

  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

Add Move modules for BLS12-381 group operations (allowing developers to implement cryptographic protocols directly in Move). Enabled in Devnet only.

@vercel
Copy link

vercel bot commented Jun 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
multisig-toolkit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
offline-signer-helper ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
sui-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
sui-kiosk ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 31, 2024 8:22am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer-storybook ⬜️ Ignored (Inspect) Jan 31, 2024 8:22am
sui-wallet-kit ⬜️ Ignored (Inspect) Visit Preview Jan 31, 2024 8:22am
wallet-adapter ⬜️ Ignored (Inspect) Jan 31, 2024 8:22am

@joyqvq
Copy link
Contributor

joyqvq commented Oct 12, 2023

do we still have plan to review and merge these?

@benr-ml
Copy link
Contributor Author

benr-ml commented Oct 13, 2023

do we still have plan to review and merge these?

Yes, will update the PR after the launch of the new drand chain, to make sure we can support it

@benr-ml
Copy link
Contributor Author

benr-ml commented Oct 22, 2023

Rebased the PR and tested it with the new drand chain. Next steps:

  • Confirm the current APIs suffice - @kchalkias @joyqvq @jonas-lj , please review ristretto255.move, bls12381.move and ec_ops.move and let me know if there are other APIs we need to expose.
  • Add the relevant flags to the protocol config (to be able to turn it on only in testnet first).
  • Handle gas.

Copy link
Contributor

@joyqvq joyqvq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. to follow up doc changes on how to use

@joyqvq joyqvq marked this pull request as ready for review October 24, 2023 15:06
move to version 36

increase gas per msm item

limit the vector length of msm

fix comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants