[move-compiler][sui-mode] Added struct declaration, private generics, and global storage checks #13482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnowacki
requested review from
amnn,
rvantonder,
cgswords,
awelc,
tzakian and
dariorussi
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
cgswords
requested changes
Sep 5, 2023
tnowacki
force-pushed
the
sm-typing-3
branch
from
0101686
to
69bda89
Compare
… and global storage checks - Added checks for structs with key (id field naming+type) - Added checks for private generics in sui::transfer and sui::event - Added checks banning global storage operations
…nerics, and global storage checks
…vate generics, and global storage checks
tnowacki
force-pushed
the
sm-typing-3
branch
from
69bda89
to
dd8e1d8
Compare
cgswords
pushed a commit
that referenced
this pull request
Sep 20, 2023
… and global storage checks (#13482) ## Description - Added checks for structs with key (id field naming+type) - Added checks for private generics in sui::transfer and sui::event - Added checks banning global storage operations ## Test Plan - Migrated tests --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [X] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Move now provides errors for all custom rules present in Sui
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Plan
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Move now provides errors for all custom rules present in Sui