Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] change display output for addresses and dynamic field in the Sui CLI client command #13581

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Sep 1, 2023

Description

This PR implements the structured output (table with header and rows) for two Sui CLI commands, sui client addresses and sui client dynamic-field.

Test Plan

Manual tests by running the commands.

Screenshot 2023-09-01 at 2 33 10 PM

image


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

This PR implements the structured output (table with header and rows) for two Sui CLI commands, sui client addresses and sui client dynamic-field.

@vercel
Copy link

vercel bot commented Sep 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:43pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 1, 2023 9:43pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 9:43pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 9:43pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 1, 2023 9:43pm

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you include a screenshot or a paste of the output from these commands in your test plan to show what the expected output is?

crates/sui/src/client_commands.rs Outdated Show resolved Hide resolved
crates/sui/src/client_commands.rs Outdated Show resolved Hide resolved
@stefan-mysten stefan-mysten force-pushed the cli_client_addresses_dynamic_fields_query branch from 2a811d0 to f8d7527 Compare September 1, 2023 21:43
@stefan-mysten stefan-mysten merged commit a83e5ac into MystenLabs:main Sep 1, 2023
36 checks passed
@stefan-mysten stefan-mysten deleted the cli_client_addresses_dynamic_fields_query branch September 1, 2023 23:46
randall-Mysten pushed a commit that referenced this pull request Sep 6, 2023
…i CLI client command (#13581)

## Description 

This PR changes the output to a formatted table for the `sui client addresses` and `sui client
dynamic-field` commands.

## Test Plan 

Manual tests by running the commands.

![Screenshot 2023-09-01 at 2 33 10
PM](https://github.com/MystenLabs/sui/assets/135084671/94b4f8cb-1b3b-4f10-9b63-684900ff9f7e)


![image](https://github.com/MystenLabs/sui/assets/135084671/15a13c2c-7738-42fb-88eb-143eb8fa45d3)



---
If your changes are not user-facing and not a breaking change, you can
skip the following section. Otherwise, please indicate what changed, and
then add to the Release Notes section as highlighted during the release
process.

### Type of Change (Check all that apply)

- [ ] protocol change
- [x] user-visible impact
- [ ] breaking change for a client SDKs
- [ ] breaking change for FNs (FN binary must upgrade)
- [ ] breaking change for validators or node operators (must upgrade
binaries)
- [ ] breaking change for on-chain data layout
- [ ] necessitate either a data wipe or data migration

### Release notes
This PR changes the output to a formatted table for the `sui client addresses` and `sui client
dynamic-field` commands.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants