Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] change the output format of sui client objects to a well formatted table #13869

Merged

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Sep 20, 2023

Description

This PR improves the way we show the output of the sui client objects command by using a well formatted table. For the objectType field, it mimics the type field from the sui explorer. Use --json for a more verbose & standard JSON output.

Test Plan

Used the command, see screenshot (overlayed a black square on the addresses, version, digest).
image


If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

The displayed output from sui client objects is improved to show details in a well-formatted table. You can use the --json flag to output a more verbose and standard JSON format.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 9:52am
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 25, 2023 9:52am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 9:52am
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 9:52am
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 25, 2023 9:52am

Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential simplification here but looks good otherwise!

crates/sui/src/client_commands.rs Outdated Show resolved Hide resolved
crates/sui/src/client_commands.rs Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants