Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] switch to a formatted table for verify bytecode meter #13870

Conversation

stefan-mysten
Copy link
Contributor

@stefan-mysten stefan-mysten commented Sep 20, 2023

Description

This PR changes the output format for sui client verify-bytecode-meter to a well formatted table.

Test Plan

image

If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.

Type of Change (Check all that apply)

  • protocol change
  • user-visible impact
  • breaking change for a client SDKs
  • breaking change for FNs (FN binary must upgrade)
  • breaking change for validators or node operators (must upgrade binaries)
  • breaking change for on-chain data layout
  • necessitate either a data wipe or data migration

Release notes

This PR changes the output format for the sui client verify-bytecode-meter command to a well formatted table.

@vercel
Copy link

vercel bot commented Sep 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mysten-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 2:42pm
sui-typescript-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 2:42pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
explorer ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 2:42pm
multisig-toolkit ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 2:42pm
sui-kiosk ⬜️ Ignored (Inspect) Visit Preview Sep 20, 2023 2:42pm

@stefan-mysten stefan-mysten changed the title Switch to a formatted table for verify bytecode meter [cli] switch to a formatted table for verify bytecode meter Sep 20, 2023
@stefan-mysten stefan-mysten requested review from amnn, wlmyng, manolisliolios and tzakian and removed request for manolisliolios September 20, 2023 15:40
Copy link
Contributor

@amnn amnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stefan-mysten stefan-mysten merged commit a9c5906 into MystenLabs:main Sep 21, 2023
36 checks passed
@stefan-mysten stefan-mysten deleted the cli_client_verify_bytecode_meter_table branch September 25, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants