Add tests for transfer gas logic #142
Conversation
| assert!(result | ||
| .unwrap_err() | ||
| .to_string() | ||
| .contains("Gas balance is 10, not enough to pay 12")); |
There was a problem hiding this comment.
So the confirmation handling has a cost!?
Note: the design is such that anybody can send a (valid) confirmation. For instance, I can emit a signed transfer to Bob, collect a confirmation, and give him the certificate instead of broadcasting it myself.
There was a problem hiding this comment.
Confirmation handling is where we actually execute the order (e.g. invoke Move bytecode). And that's where we deduct gas (in this case, we are deducting the gas for Transfer order). So if the gas is insufficient to execute the order, it will error out during confirmation handling step.
Are you suggesting to do order execution during the order handling step instead of order confirmation step?
There was a problem hiding this comment.
Are you suggesting to do order execution during the order handling step instead of order confirmation step?
Not at all, I was trying to figure out why you got to a cost of 12 gas, rather than the minimum of 8.
There was a problem hiding this comment.
Ah ok, that's because of this: https://github.com/MystenLabs/fastnft/blob/main/fastx_types/src/gas.rs#L100
The current gas cost for transferring an object is based on the size of the object, which is obviously arbitrarily made up by me at this point.
There was a problem hiding this comment.
Ah, well, that will be a finnicky test to maintain. But that's certainly an acceptable state for now.
Added a few tests for transfer gas logic.
Added minimum gas requirement check logic that I forgot in the previous PR.