[cli/alias] Keytool update alias #15162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefan-mysten
requested review from
amnn
and removed request for
patrickkuo and
joyqvq
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
stefan-mysten
force-pushed
the
keytool_update_alias
branch
from
9212fd2
to
acd1902
Compare
dariorussi
approved these changes
Dec 8, 2023
stefan-mysten
force-pushed
the
keytool_update_alias
branch
from
b04c190
to
d1b6e3c
Compare
This reverts commit d1b6e3c.
stefan-mysten
force-pushed
the
keytool_update_alias
branch
from
821dfab
to
c0e0b25
Compare
gdanezis
pushed a commit
that referenced
this pull request
Dec 15, 2023
## Description Provide a new command for updating the alias of an address. The new command `keytool update-alias` takes an old alias that needs to be updated, and optionally, a new alias name. If there is no new alias given, a new random alias will be generated. Furthermore, the alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_). An example for using this command is: `sui keytool update-alias test high_yield_address`, which outputs the following text: `Old alias test was updated to high_yield_address` ## Test Plan Two new tests for FileBasedKeystore and InMemKeystore. <img width="869" alt="image" src="https://github.com/MystenLabs/sui/assets/135084671/2f3cecd1-d283-4a9d-8995-d3999888a9e9"> --- If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process. ### Type of Change (Check all that apply) - [ ] protocol change - [x] user-visible impact - [ ] breaking change for a client SDKs - [ ] breaking change for FNs (FN binary must upgrade) - [ ] breaking change for validators or node operators (must upgrade binaries) - [ ] breaking change for on-chain data layout - [ ] necessitate either a data wipe or data migration ### Release notes Added support for updating an alias of an address in the Sui CLI. The alias must start with a letter and can contain only letters, digits, hyphens (-), or underscores (_). Try it out through this command: `sui keytool update-alias --help`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a new command for updating the alias of an address. The new command
keytool aliashas one flag--update, followed by an old alias that needs to be updated, and optionally, a new alias name. If there is no new alias given, a new random alias will be generated.An example for using this command is:
sui keytool update-alias test high_yield_address, which outputs the following text:Old alias test was updated to high_yield_addressTest Plan
Two new tests for FileBasedKeystore and InMemKeystore.
If your changes are not user-facing and not a breaking change, you can skip the following section. Otherwise, please indicate what changed, and then add to the Release Notes section as highlighted during the release process.
Type of Change (Check all that apply)
Release notes
Added support for updating an alias of an address in the Sui CLI. See the console help for this command using:
sui keytool update-alias --help.