Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add explanation on how to use take_object_by_id in tests #1584

Merged
merged 1 commit into from
Apr 26, 2022

Conversation

lxfind
Copy link
Contributor

@lxfind lxfind commented Apr 26, 2022

Add tutorial in the second chapter to explain how to take objects using ID when there are multiple of the same type.
Also rename get_last_created_object_id to last_created_object_id to make it shorter.

@lxfind lxfind added the Type: Documentation Improvements or additions to documentation label Apr 26, 2022
@Clay-Mysten Clay-Mysten changed the title [Doc] Add explainations on how to use take_object_by_id in tests [Doc] Add explanation on how to use take_object_by_id in tests Apr 26, 2022
Copy link
Contributor

@Clay-Mysten Clay-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Xun! Markdown LGTM.

@lxfind lxfind enabled auto-merge (squash) April 26, 2022 15:48
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #1584 (60ce918) into main (c1e46f0) will decrease coverage by 3.75%.
The diff coverage is 64.94%.

@@            Coverage Diff             @@
##             main    #1584      +/-   ##
==========================================
- Coverage   82.19%   78.43%   -3.76%     
==========================================
  Files         104      122      +18     
  Lines       21145    21895     +750     
==========================================
- Hits        17380    17174     -206     
- Misses       3765     4721     +956     
Impacted Files Coverage Δ
faucet/src/errors.rs 0.00% <0.00%> (ø)
faucet/src/requests.rs 0.00% <0.00%> (ø)
faucet/src/responses.rs 0.00% <0.00%> (ø)
network_utils/src/network.rs 36.64% <0.00%> (-0.78%) ⬇️
sui/src/benchmark.rs 0.00% <0.00%> (ø)
sui/src/benchmark/bench_types.rs 0.00% <0.00%> (ø)
sui/src/benchmark/load_generator.rs 0.00% <0.00%> (ø)
sui/src/benchmark/transaction_creator.rs 0.00% <0.00%> (ø)
sui/src/benchmark/validator_preparer.rs 0.00% <0.00%> (ø)
sui/src/bin/sui-move.rs 3.12% <ø> (ø)
... and 115 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6806d22...60ce918. Read the comment docs.

@lxfind lxfind merged commit 59a491c into main Apr 26, 2022
@lxfind lxfind deleted the add-get-object-by-id-doc branch April 26, 2022 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants