[shared-object-deletion] Turn on shared object deletion in mainnet #16008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzakian
requested review from
oxade,
amnn,
wlmyng,
stefan-mysten,
emmazzz,
suiwombat and
mystenmark
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
tzakian
force-pushed
the
tzakian/sod_mainnet
branch
from
55dde7f
to
336f80f
Compare
lavindir
approved these changes
Jan 31, 2024
lavindir
reviewed
Jan 31, 2024
| "sequenceNumber": 0 | ||
| }, | ||
| "last": { | ||
| "digest": "4KMiBygiY5pNj53QJKDmHGkcXywEUrEwg85KRQFjAhty", |
There was a problem hiding this comment.
curious why all these values changed?
There was a problem hiding this comment.
They just generally have shifted every time there is a new protocol version. So my understanding is there's some deterministic state (e.g., genesis) that changes with the new protocol version (similar to the configs that also need to be updated with new values after a protocol version bump).
tzakian
force-pushed
the
tzakian/sod_mainnet
branch
from
336f80f
to
99064b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turn on shared object deletion in mainnet. This is a flag-only PR (+ updates) that adds a new protocol version (version 36).
Test Plan
Existing tests + has been running in devnet/testnet for the past couple months.
If your changes are not user-facing and do not break anything, you can skip the following section. Otherwise, please briefly describe what has changed under the Release Notes section.
Type of Change (Check all that apply)
Release notes
Enable shared object deletion in mainnet.