[Framework] Receiver function aliases for package.move #17205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`sui::package` has definitions of multiple types where we have had to disambiguate function names. Adding some receiver function aliases so that we don't need to use the disambiguated names when they are called as receiver functions. ## Test plan CI
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
tnowacki
approved these changes
Apr 17, 2024
|
|
||
| /// Allows calling `.module_` to access the name of the module a | ||
| /// `Publisher` was derived from. | ||
| public use fun published_module as Publisher.module_; |
There was a problem hiding this comment.
Suggested change
| public use fun published_module as Publisher.module_; | |
| public use fun published_module as Publisher.`module`; |
Thoughts? Feelings?
There was a problem hiding this comment.
I have ...mixed feelings, but not very strong, so happy to be persuaded.
There was a problem hiding this comment.
Will land, but let me know if you do feel strongly about using the backticks for this (for me it makes the receiver syntax fiddlier/more conspicious than the non-receiver function, vs tacking an underscore on the end).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sui::packagehas definitions of multiple types where we have had to disambiguate function names. Adding some receiver function aliases so that we don't need to use the disambiguated names when they are called as receiver functions.Test plan
CI
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.
sui::publishermodule.