Added retry for gateway tx #1765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxade
requested review from
lxfind,
patrickkuo,
gdanezis,
bmwill,
longbowlu and
asonnino
oxade
commented
May 4, 2022
| @@ -48,6 +48,8 @@ pub type GatewayClient = Box<dyn GatewayAPI + Sync + Send>; | |||
| pub type GatewayTxSeqNumber = u64; | |||
|
|
|||
| const MAX_TX_RANGE_SIZE: u64 = 4096; | |||
| /// Number of times to retry failed TX | |||
| const MAX_NUM_TX_RETRIES: usize = 5; | |||
There was a problem hiding this comment.
Would ideally want a compile-tile way to assert this is always non zero
lxfind
reviewed
May 4, 2022
lxfind
reviewed
May 4, 2022
lxfind
approved these changes
May 4, 2022
longbowlu
pushed a commit
that referenced
this pull request
May 12, 2022
* Added retry for gateway tx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles (3) in #1393 since it's a simple case