[CLI-PTB] Add integer inferrence #17850
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue where if a type was not annotated on an integer value we would set its type to
u64
. This could lead to errors with things likeThis now adds an
InferredNum
argument, and also adds type arguments to pure value serialization at which point we will select the type for the inferred num, if no type is provided we default to au64
.This also has the added benefit of performing (lightweight!) type checking during the building of the PTB, so we will now get build errors for things like
Test plan
Added additional tests and updated existing tests.
Release notes
Check each box that your changes affect. If none of the boxes relate to your changes, release notes aren't required.
For each box you select, include information after the relevant heading that describes the impact of your changes that a user might notice and any actions they must take to implement updates.