[Sui Framework] Expose getter for current epoch number #1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also expose a test-only function for advancing the epoch number. This is useful for contracts that need time, at least until we have a more fine-grained timestamping scheme.
lxfind
approved these changes
May 16, 2022
|
Although I don't mind adding the getter, I think this might be the wrong way to expose epoch: anyone who wants to access epoch number has to pass in a shared object. Should we add epoch to TxContext? |
damirka
approved these changes
May 16, 2022
|
Agree wıth @lxfind, TxContext does seem like the best place. |
|
Yep, great call on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also expose a test-only function for advancing the epoch number. This is useful for contracts that need time, at least until we have a more fine-grained timestamping scheme.