Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sui: limit when the build script needs to be run #2026

Merged
merged 1 commit into from
May 18, 2022

Commits on May 18, 2022

  1. sui: limit when the build script needs to be run

    Support for embedding the git revision inside the wallet cli was added
    back in 96611e0 (wallet: log git revision on start, 2022-04-22). This
    was done by using a build.rs file to run a few git commands to query for
    the git revision of HEAD and if the working directory was dirty or not.
    
    The addition of this feature had the unintended consequence of causing
    a ton of code to be re-build anytime any file in the `sui` crate was
    changed. This is due to the fact that, by default, a build.rs file is
    re-run anytime any file anywhere in the crate (integration tests and
    examples included) [1].
    
    This patch fixes this by only having cargo re-run the build script when
    the build.rs file is changed.
    
    [1] https://doc.rust-lang.org/cargo/reference/build-scripts.html#cargorerun-if-changedpath
    bmwill committed May 18, 2022
    Configuration menu
    Copy the full SHA
    66950ca View commit details
    Browse the repository at this point in the history