Add dependent package objects to input_objects during module publish #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
requested review from
huitseeker,
awelc,
sblackshear,
gdanezis,
stella3d and
oxade
gdanezis
requested changes
Jan 29, 2022
lxfind
force-pushed
the
check-dependent-packages
branch
from
9a46c74
to
13783dd
Compare
lxfind
changed the title
|
Redid the fix based on @gdanezis 's suggestion. Instead of checking it manually, these dependency packages are now part of the input_objects. |
gdanezis
approved these changes
Jan 30, 2022
lxfind
force-pushed
the
check-dependent-packages
branch
from
13783dd
to
cc5848b
Compare
|
OK. Renamed the enum to |
gdanezis
approved these changes
Jan 31, 2022
| @@ -242,6 +244,28 @@ impl PartialEq for SignedOrder { | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Copy, Debug, Eq, PartialEq)] | |||
| pub enum InputObjectKind { | |||
lxfind
force-pushed
the
check-dependent-packages
branch
from
cc5848b
to
4f3de32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #284.
The problem here is that during module publishing, we will eventually need to read more objects on-chain due to module dependency (the to-be-published package can depend on other package objects). We need to first check if these objects exist on-chain before executing the publishing.
If we don't do so, in the case when some authorities are out-of-sync and don't contain some of the dependent packages, we could end up charging failure gas, leading to inconsistent state!
This PR fixes it by adding these implicit dependencies to
input_objectsso that they are checked the same way just like other input objects.One specialty here is that we don't have the digest when retrieving these dependency objects, and we don't care about it anyway since published packages never change on-chain. To handle this, we add an
InputTypeenum that gets returned along with each input object to indicate their types. Doing so allows us to skip the digest check on the dependency objects. It also makes it slightly cleaner to check on transfer object and gas object.