[sui framework] add vec_map::remove_entry_by_idx

[juzybits]

No description provided.

[sblackshear]

Looks excellent, thanks!

Would you mind adding some tests for the success and failure case in https://github.com/MystenLabs/sui/blob/17f6960f8c1ab034ab05f00e5d6babb2877f451f/crates/sui-framework/tests/vec_map_tests.move ?

[juzybits]

Done!
In addition to the new tests for remove_entry_by_idx, I pushed an additional commit modifying an existing test that looked like a copy/paste mistake.

[sblackshear]

Good catch on the older test

[sblackshear]

Ah, I forgot there's one more step to go through here. Adding a new function to the Sui framework changes the genesis blob, and we have snapshots of this blob that need to be updated. Please do:

cargo install cargo-insta
cd sui/crates/sui-config/tests # where the snapshots live
cargo insta review # type a to accept genesis snapshot changes
cargo insta test # to verify changes

[sblackshear]

For updating the genesis snaphsot

[juzybits]

That seems to have worked (it updated crates/sui-config/tests/snapshots/snapshot_tests__empty_genesis_snapshot_matches.snap).

[sblackshear]

I think crates/sui-cost has a snapshot that needs to be updated in a similar way

[juzybits]

Done! Results show that computationCost increased by 1 in some cases like Publish - I guess this is to be expected.

Cool tooling :). I'll try to keep all this in mind for the future.

[juzybits]

Rebased my changes on top of main to avoid merge conflicts.