Adaptive cleanup of mutex table #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadhansood
requested review from
mystenmark,
gdanezis,
andll and
velvia
and removed request for
mystenmark
mystenmark
reviewed
Sep 7, 2022
| @@ -296,3 +333,47 @@ async fn test_mutex_table_bg_cleanup() { | |||
| assert!(locked.is_empty()); | |||
| } | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
You probably want #[tokio::test(flavor = "current_thread", start_paused = true)]
There was a problem hiding this comment.
thanks, good point and done
sadhansood
force-pushed
the
sadhan/mutex_table_cleanup_threshold
branch
from
4544872
to
409b299
Compare
mystenmark
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current mutex table cleanup is not very good with handling load spikes since it runs at a fixed time period. We would want to also do cleanup if size of the table goes over a threshold. This diff adds a size() function (which will also be useful to track #entries in the table) as well as cleanup based on size threshold