Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explorer] Fixes text overhang in failure message in Transaction Results Page #4462

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented Sep 5, 2022

Current
image

Before
image

@apburnie apburnie marked this pull request as ready for review September 5, 2022 10:20
@apburnie apburnie requested a review from Jibz1 September 5, 2022 10:20
Copy link
Collaborator

@mystie711 mystie711 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Andrew47 could i request we add the info icon and round the corners to align with the spec here,
https://www.figma.com/file/kSD0qXCIDZA4KQVNepA5hR/02-Explorer?node-id=202%3A43102

For mobile, the wrapping and flow to "hug content" like you have in screenshot you attached looks good.

@apburnie
Copy link
Contributor Author

apburnie commented Sep 6, 2022

@Andrew47 could i request we add the info icon and round the corners to align with the spec here, https://www.figma.com/file/kSD0qXCIDZA4KQVNepA5hR/02-Explorer?node-id=202%3A43102

For mobile, the wrapping and flow to "hug content" like you have in screenshot you attached looks good.

Thank you @mystie711 for raising the issue that a number of deltas have emerged between the Transactions Results Status Message on the website and that in the Figma Design.

I've put together the PR #4485 to address the gaps between the Figma Design and the website. There are other deltas including differences in the font weight and colours used. Let me know whether PR 4485 meets the problem or if further alterations are required.

The scope of this PR 4462 is specifically about the text overhang issue raised by @adeabiodun. From the above feedback, can we get an approval of this PR 4462 to fix the accute issue of the text overhanging on mobile?

@apburnie apburnie self-assigned this Sep 6, 2022
@stella3d stella3d self-requested a review September 6, 2022 16:51
@apburnie apburnie merged commit 9fb2ddc into main Sep 7, 2022
@apburnie apburnie deleted the fixFailMsgOverhang branch September 7, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants