Update mysten infra ptr with new db map #4496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andll
approved these changes
Sep 6, 2022
| @@ -1418,7 +1418,7 @@ impl<T: ModuleResolver> ModuleResolver for ResolverWrapper<T> { | |||
| // The primary key type for object storage. | |||
| #[serde_as] | |||
| #[derive(Eq, PartialEq, Clone, Copy, PartialOrd, Ord, Hash, Serialize, Deserialize, Debug)] | |||
| pub(crate) struct ObjectKey(pub ObjectID, pub VersionNumber); | |||
| pub struct ObjectKey(pub ObjectID, pub VersionNumber); | |||
There was a problem hiding this comment.
Curious why this needed to change?
There was a problem hiding this comment.
Curious why this needed to change?
Without this, we will not be able to dump/debug the DB in external utils as this will leak the private type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes latest mysten infra features
This PR also uses a safer DBDump which enforces dump can only be called in secondary/read-only mode
We also expose better DBMap configurations.