New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove batch_info_request_start_seq and add follower_start_seq_num #4501

Merged

longbowlu merged 1 commit into main from adjust-seq-num-metrics

Sep 6, 2022

Contributor

longbowlu commented Sep 6, 2022

remove batch_info_request_start_seq on the client side as it's not configured correctly. Instead we should use safe_client_follower_streaming_from_seq_number_by_address which is already there.
add follower_start_seq_num on the server side as a histogram with the proper bucket configs.


          remove batch_info_request_start_seq and add follower_start_seq_num

2c5e20a

longbowlu requested review from velvia, lxfind, bmwill, lavindir and mystenmark

September 6, 2022 23:45

bmwill approved these changes

View reviewed changes

longbowlu merged commit 9064487 into main

longbowlu deleted the adjust-seq-num-metrics branch

September 6, 2022 23:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment