Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Explorer] Clicking on the Object Type should go to the Address/Module associated with the Type string not the last transaction #4521

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

apburnie
Copy link
Contributor

@apburnie apburnie commented Sep 8, 2022

The Problem

Go to https://explorer.devnet.sui.io/objects/0x125590262eff8187d90b220a2e64b053ad3f3fa8. When the user clicks on the Type field, they go to 0xa276e9b404ccd264eb592df850a8064538ba8e89 and not 0x2.

Proposed Solution

The package and address should be extracted from the type string and not the details on the last transaction

Demo

firefox_NKV5U7mSiK.mp4

@apburnie apburnie marked this pull request as ready for review September 8, 2022 09:51
Copy link
Contributor

@666lcz 666lcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@apburnie apburnie merged commit 5d346fd into main Sep 8, 2022
@apburnie apburnie deleted the fixTypeJumpToPackage branch September 8, 2022 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants