Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Added support for object vectors to Sui JSON #4526

Merged
merged 3 commits into from
Sep 8, 2022
Merged

Conversation

awelc
Copy link
Contributor

@awelc awelc commented Sep 8, 2022

This PR adds support for recently added object vectors (#4349) to Sui JSON enabling object vectors use in the CLI.

@awelc awelc requested review from tnowacki and oxade September 8, 2022 17:36
@awelc awelc self-assigned this Sep 8, 2022
@github-actions github-actions bot added the Type: Documentation Improvements or additions to documentation label Sep 8, 2022
@oxade
Copy link
Contributor

oxade commented Sep 8, 2022

Thanks @awelc can you please show a sample usage of it in CLI?
Just so we see the syntax etc. CLI has been known to be finicky with vectors.

@awelc
Copy link
Contributor Author

awelc commented Sep 8, 2022

Thanks @awelc can you please show a sample usage of it in CLI? Just so we see the syntax etc. CLI has been known to be finicky with vectors.

Examples have been added to the docs (doc/src/build/cli-client.md). Did you mean adding (integration?) tests?

Copy link
Contributor

@randall-Mysten randall-Mysten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates to the .md files. Added a few suggested updates for clarity and style consistency.

doc/src/build/cli-client.md Outdated Show resolved Hide resolved
doc/src/build/cli-client.md Outdated Show resolved Hide resolved
Comment on lines +970 to +972
To gain a deeper view into the object, include the
> `--json` flag in the `sui client` command to see the raw JSON representation
> of the object.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To gain a deeper view into the object, include the
> `--json` flag in the `sui client` command to see the raw JSON representation
> of the object.
To view the raw JSON representation of the object, include the
> `--json` flag in the `sui client` command. For example,
`sui client --json`

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is unrelated to the current PR and does not sound quite right. For the sake of expediency I suggest changing it in a separate PR if necessary

awelc and others added 2 commits September 8, 2022 12:46
Co-authored-by: Randall-Mysten <109545725+randall-Mysten@users.noreply.github.com>
Co-authored-by: Randall-Mysten <109545725+randall-Mysten@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants