wallet-ext: fix connection request pending #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* connect to background service during the first message from a dapp. After that always reconnect
* adds extra permission `tabs` for the extension
* notify all the tabs with same origin with the permission for the permission response * when there is another pending request for the same origin throw an error to the dapp as before but focus or open the permission popup * add validation for the permission types
pchrysochoidis
requested review from
Jibz1,
666lcz,
gegaowp and
Jordan-Mysten
Jibz1
approved these changes
Sep 14, 2022
pchrysochoidis
deleted the
pc-wallet-ext-3881-fix-connection-request-pending
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permission Request while another one is pending
Before
Screen.Recording.2022-09-08.at.21.43.16.mov
After
Screen.Recording.2022-09-08.at.21.42.03.mov
Fix permission request response handling while background service is inactive
Before
Screen.Recording.2022-09-08.at.21.11.32.mov
After
Screen.Recording.2022-09-08.at.21.41.27.mov
fixes: #3881