Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only verify simtest build, not test runs (temporarily broken due to anemo) #4546

Merged
merged 2 commits into from
Sep 9, 2022
Merged

Only verify simtest build, not test runs (temporarily broken due to anemo) #4546

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f993ca
Support for `cargo simtest build` command
mlogan Sep 9, 2022
f1dc316
Only verify simtest build, not test runs (temporarily broken due to a…
mlogan Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:
- uses: taiki-e/install-action@nextest
- name: cargo simtest
run: |
scripts/simtest/cargo-simtest simtest
scripts/simtest/cargo-simtest simtest build

# This is a no-op job that allows the resulting action names to line up when
# there are no rust changes in a given PR/commit. This ensures that we can
Expand Down
9 changes: 7 additions & 2 deletions scripts/simtest/cargo-simtest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,13 @@ else
echo "Using MSIM_TEST_SEED=$MSIM_TEST_SEED from the environment"
fi

cargo nextest run \
--cargo-profile simulator \
CARGO_COMMAND=(nextest run --cargo-profile simulator)
if [ "$1" = "build" ]; then
shift
CARGO_COMMAND=(build --profile simulator)
fi

cargo ${CARGO_COMMAND[@]} \
--config 'build.rustflags = ["--cfg", "msim"]' \
--config 'patch.crates-io.tokio.git = "https://github.com/MystenLabs/mysten-sim.git"' \
--config 'patch.crates-io.tokio.rev = "15dff80e8e69218bc20b08a5ef91a4f156e626ac"' \
Expand Down