Fix shared object retries #4579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, transaction input checker loads the latest version of shared objects. The fix is to instead load the sequenced versions, but only during certificate processing.
lxfind
approved these changes
Sep 12, 2022
As discussed in slack, this would be misleading, since it doesn't actually get the latest objects in the case of owned objects. |
andll
reviewed
Sep 12, 2022
| InputObjectKind::MovePackage(id) => self.get_object(id)?, | ||
| InputObjectKind::SharedMoveObject(id) => match shared_locks.get(id) { | ||
| Some(version) => self.get_object_by_key(id, *version)?, | ||
| None => None, |
There was a problem hiding this comment.
I think this should be something like shared_locks.get(id).expect("Did not find shared lock for shared object") right?
Since this is basically an invariant violation, we should not just return None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4387
The basic idea here is that transaction_input_check should always load the object versions that will be consumed by the TX, rather than the latest versions in the DB. This behavior comes for free with owned objects, since those are already specified by ObjRef. By using the shared lock table, we provide the same behavior for shared objects.