Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consensus time metrics on SUI side #4584

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Add consensus time metrics on SUI side #4584

merged 1 commit into from
Sep 14, 2022

Commits on Sep 12, 2022

  1. Add consensus time metrics on SUI side

    This diff adds two metrics
    (a) `sequencing_certificate_latency`: histogram for consensus adapter that measures latency of transaction sequencing. This should be a key metric that shows how much consensus contributes to overall transaction latency. Normally in the stress test tool we should see `shared_object_latency = owned_object_latency + sequencing_certificate_latency`.
    Metric that existed before, `sequencing_certificate_control_delay` is a proxy metric(it indicates consensus timeout derived from the current latency) and is hard to use directly.
    
    (b) `handle_consensus_duration_mcs` is a metric that can be used to derive the utilization of the `handle_consensus_transaction` task. The metrics is simply a sum of execution times. Based on this metric we can build a graph `rate(handle_consensus_duration_mcs) / 1_000_000`, this graph will show 'utilization' of the consensus task on sui side. If value here gets close to 1.0 it means that consensus is generating tasks faster than sui can assign shared object locks.
    
    We will need to add something similar to (b) on the narwhal side to include batch waiter etc time.
    andll committed Sep 12, 2022
    Configuration menu
    Copy the full SHA
    3dd13f5 View commit details
    Browse the repository at this point in the history