[gas] Fix potential data race in gas object check #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lxfind
force-pushed
the
gas-fix-potential-data-race
branch
from
1792b14
to
1fd360d
Compare
velvia
reviewed
Sep 26, 2022
| @@ -90,7 +91,7 @@ where | |||
| #[instrument(level = "trace", skip_all)] | |||
| async fn check_gas<S>( | |||
| store: &SuiDataStore<S>, | |||
| gas_payment_id: ObjectID, | |||
| gas_payment: &ObjectRef, | |||
There was a problem hiding this comment.
Technically the digest isn't necessary and we can just pass the ID and version here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what conditions would trigger a real problem in prod, fix it just in case.
When checking gas and creating gas meter, we should also make sure we use the requested version instead of latest version.
Resolves #4597