[Explorer] Adds Name field to Owned NFTs #4593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sui-explorer
Type: Documentation
apburnie
force-pushed
the
addNameToOwnedObject
branch
from
4d41c1b
to
9544832
Compare
github-actions
bot
removed
the
Type: Documentation
apburnie
force-pushed
the
addNameToOwnedObject
branch
from
9544832
to
52a120e
Compare
apburnie
requested review from
stella3d,
Jibz1,
Jordan-Mysten and
mystie711
Jordan-Mysten
approved these changes
Sep 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion with @mystie711 on Slack and the updated Figma Design, this PR adds the human-readable name as a field for each Owned NFT.
As can be seen when looking at http://localhost:3000/addresses/0x7c824faed726e261ab672f7132844a1766013d7f, this can handle both the case where there is a name (left) and there is not a name (right):