move quorum driver from its own crate to sui-core #4611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have no problem with moving this code, but can you explain what you mean by integrating with node sync? I don't think any integration with that component per se will be required. Instead, QD should only interface with AuthorityState - just call handle_node_sync_certificate once you have the effects cert. |
mystenmark
approved these changes
Sep 13, 2022
On second thought, you do probably want to use node sync, in case there are missing dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply moves quorum drive from its own crate to sui-core. The main reason for this change is we'd like to make integrate quorum drive with other components in sui-core (e.g. node sync) to proactively execute finalized txns locally.
Today
quorum-driverdepends onsui-core, the integration will makesui-coredepend onquorum-driverforming a circular dependency.