Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update narwhal pointer #4628

Merged
merged 5 commits into from
Sep 14, 2022
Merged

chore: update narwhal pointer #4628

merged 5 commits into from
Sep 14, 2022

Conversation

bmwill
Copy link
Contributor

@bmwill bmwill commented Sep 14, 2022

Notable changes:

  • Narwhal has been fully converted to use quic for p2p communication
  • primary-to-primary and worker-to-primary have been merged into a single primary-address
  • worker-to-worker and primary-to-worker have been merged into a single worker-address
  • narwhal uses a network key in addition to a consensus key for TLS between nodes

@huitseeker
Copy link
Contributor

Labeling as breaking change for the need to re-genesis.

@arun-koshy
Copy link
Contributor

Awesome seeing the streamlined network interfaces!

Do you need to also change the keytool? If you do end up changing it can you add the Worker Keypair as an output too 🙏🏽

@joyqvq joyqvq self-requested a review September 14, 2022 19:01
@bmwill bmwill merged commit f34e9d6 into MystenLabs:main Sep 14, 2022
@bmwill bmwill deleted the update-narwhal branch September 14, 2022 19:07
@bmwill
Copy link
Contributor Author

bmwill commented Sep 14, 2022

@arun-koshy I don't think/know if we need to change the keytool, but we can look into that in another PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants