[explorer] Remove targeted builds for explorer #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randall-Mysten
approved these changes
Sep 15, 2022
| ``` | ||
|
|
||
| Then, click the green button at the top and select the option 'Custom RPC URL'. Type the Custom RPC URL into the input box that emerges. | ||
| If you want to use the explorer with another network, you can select your preferred network in the header of the explorer. |
There was a problem hiding this comment.
Wouldn't they need to choose Custom RPC URL and then enter the IP address to the server?
There was a problem hiding this comment.
For custom fullnodes, yes.
Jordan-Mysten
changed the title
Co-authored-by: Randall-Mysten <109545725+randall-Mysten@users.noreply.github.com>
apburnie
reviewed
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the targeted builds for explorer, and instead infers the network information from the URL. The goal of this is to simplify the build and deploy process of the explorer.
As part of this change, the default network for local development has changed to localnet. In general, I think this is a good default, and can still be overridden in the UI easily. This can also be overridden via the
VITE_NETWORKenvironment variable, and therpcUrlquery parameter. If you primarily develop against devnet, you should be able to just set the network once, and the localStorage preference should keep it set for you.